-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "governance" system contract that will be able to initiate rollbacks #471
Open
avm
wants to merge
1
commit into
main
Choose a base branch
from
governance-contract
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrskv
reviewed
Mar 6, 2025
var _ ReadWritePrecompiledContract = (*governance)(nil) | ||
|
||
func (g *governance) RequiredGas([]byte, StateDBReadOnly) (uint64, error) { | ||
return 10, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder about putting all these gas values as constants into a single file. Not relevant to this PR tho
olegrok
reviewed
Mar 7, 2025
olegrok
reviewed
Mar 7, 2025
shermike
reviewed
Mar 7, 2025
0c4d3fc
to
3eeb125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During network launch, we may encounter misconfigurations, vulnerabilities or bugs in the validators or the provers that may result in malicious or breaking changes to the state of the blockchain. One way to deal with them at early stages of the mainnet is "rolling back" to a known good state when an authority decides to do so.
This patch adds a "governance" system contract on the main shard and a corresponding precompile, accepting rollback transactions signed by a "sudo key" (currently the same as the "main key" of the built-in system smart account). The rollback functionality itself will be implemented by following patches.